Question: hopefully the most anyone will need to do is just re-run generate-interfaces. I don't think it'll come up unless they are adding new nodes looks like lint on travis is still broken. make lint && make flow && echo $? exits 0 locally on a fresh clone + make bootstrap ¯\_(ツ)_/¯ happy to keep digging if you think it's worthwhile thanks so much for getting these in!

Asked By
jbrown215
Asked At
2017-08-15 21:42:34

Found 15 possible answers.

User Answered At Possible Answer
hzoo 2017-08-15 22:02:57 nah
anup 2017-08-16 09:27:38 hello guys! working on my first PR for Babel: I have made the changes locally but there are 7 tests that are showing status pending. Rest all (2245 tests passed)
➜  babel git:(add-configurable-transform-class-properties) ✗
fatal: failed to write commit object
error: gpg failed to sign the data
fatal: cannot run gpg2: No such file or directory
 ✔ Running tasks for *.js
> husky - node v8.3.0
> husky - npm run -s precommit
➜ babel git:(add-configurable-transform-class-properties) ✗ git commit -m "Add 'configurable' property to class fields" I am getting the following error: hi guys, I am not able to add a commit message after making changes locally.
sven 2017-08-16 09:46:20 you're missing gpg2, do you use sign your commits?
anup 2017-08-16 09:47:18 yes, I sign my commits (asking stupid questions, since this is my first PR :sweat_smile: ) when I ran the tests locally it passed 2245 tests and 4 are in pending state. Is it normal? unsign’ing my commits for the moment. Thanks @sven It works perfectly fine for me in other projects
jameshenry 2017-08-16 12:59:34 Is it a known issue that babylon will not build on master right now?
sven 2017-08-16 12:59:56 No AFAIK The latest commit built - https://github.com/babel/babylon/commits/master
jameshenry 2017-08-16 13:00:29 @jameshenry uploaded a file: Pasted image at 2017-08-16, 2:00 PM https://babeljs.slack.com/files/jameshenry/F6P86LTMH/pasted_image_at_2017_08_16_02_00_pm.png Maybe a patch version of a dep that has come out since the latest commit build has broken things? Weird, I’m just running yarn
sven 2017-08-16 13:01:03 yes, I already saw this somewhere I'll try on my side
jameshenry 2017-08-16 13:01:30 Thanks!
sven 2017-08-16 13:02:08 Do you have any npm link? Related issue https://github.com/babel/babel/issues/5797
hzoo 2017-08-16 14:09:23 arrowFunctionToExpression means it's downloading an older version of babel-traverse
jameshenry 2017-08-16 14:39:23 Thanks guys, sorry I had to jump on a call for a bit Werid Hmm did not help, tried with both yarn and npm clients, after cleaning the cache of both I will try and clean my cache
hzoo 2017-08-16 14:48:24 is it the yarn version?
jameshenry 2017-08-16 15:00:30 No, upgrading doesn’t seem to help, and I did also try with the npm client ¯\_(ツ)_/¯ After runnning yarn It’s back in there, but everything works each time I run yarn Got it working by manually hacking out the babel-core 6 reference from yarn.lock Can confirm I am resolving "_resolved": " ", somehow I’ll keep hacking around for a solution :sweat_smile:
hzoo 2017-08-16 15:15:15 ok the yarn.lock is messed up then, need to redo it

Related Questions