Question: why would you make that change btw? Array is already a global

Asked By
ljharb
Asked At
2017-09-20 21:50:57

Found 15 possible answers.

User Answered At Possible Answer
wagonofjustice 2017-09-20 21:51:49 I'm not abreast of the entire reason, but it has something to do with secure computation I'll have to create a member expression outside of it, maybe? ah, and I know the solution I'm just looking into the project now and migrating the compiler to babel
nicolo-ribaudo 2017-09-20 21:54:31 @wagonofjustice Something like this? https://astexplorer.net/#/gist/e9ca1c26ad4ca7202c11d8227e31bb2a/61a5ec3f8e37662c90c56803c5877020ffc01d1e
ljharb 2017-09-20 21:54:39 at that point then global is as “insecure” as Array is, but k
wagonofjustice 2017-09-20 21:54:49 this is mostly for a test suite, so that particular implementation is probably not the end goal but just an assertion for rerouting variables onto the global object howabout that too, you can use .replace on .get ah yes, that's great nicolo, much thanks
nicolo-ribaudo 2017-09-20 21:56:23 Or maybe this, which also works if Array isn't part of a member expression: https://astexplorer.net/#/gist/e9ca1c26ad4ca7202c11d8227e31bb2a/fd5fa8640ed0493d91d08631ba5e27ec0f04ec49 Yes, .get returns a path
zoe 2017-09-20 21:56:49 is there any documentation for how test cases should be written? I was just looking through test/fixtures/experimental/uncategorised and it seems like there are lots of random numbers. I am sure that they are not random, but I would love to know what they correspond to. Thanks!
existentialism 2017-09-20 21:57:31 in babylon? ya they’re just incremented numbers, not great. for general notes on how to create tests for babylon https://github.com/babel/babylon/blob/master/CONTRIBUTING.md we’ve been needing to clean it up
zoe 2017-09-20 21:58:14 alright, thanks can/should I clean up the directors and submit a pr?
existentialism 2017-09-20 21:58:48 ideally, instead of a number, you’d give it something descriptive like bylon/test/fixtures/experimental/export-named/fails-with-foo directors?
wagonofjustice 2017-09-20 21:59:11 hmm, I'm wondering if I would be able to use that nicolo, since I'm executing this not from the memberExpression node, but from a function declaration node
zoe 2017-09-20 21:59:51 @existentialism I mean name/ organize all of the folders in babylon/test/fixtures/experimental/uncategorised
wagonofjustice 2017-09-20 21:59:53 the scenario here is that there is a function that returns an assignment expression I have to grab that return statement and rewire it a little bit
existentialism 2017-09-20 22:00:28 @zoe sure, maybe in small, easy to review batches? i guess there arent a ton in the experimental folder
zoe 2017-09-20 22:00:54 yeah, I think
existentialism 2017-09-20 22:00:57 check out https://github.com/babel/babylon/tree/master/test/fixtures/es2015/uncategorised :slightly_smiling_face:

Related Questions