Question: already did… I need to run make bootstrap every time I make a change to e.g. babel-helpers?

Asked By
nuragic
Asked At
2017-12-05 14:21:02

Found 15 possible answers.

User Answered At Possible Answer
nicolo-ribaudo 2017-12-05 21:15:48 make bootstrap is mainly needed to link the correct dependencies in the monorepo.... Usually when I get the Cannot find module '../lib' error is because either make build/watch failed or I didn't run make bootstrap :thinking_face:
nuragic 2017-12-06 16:26:08 @nicolo-ribaudo I guess the problem is the make watch script because I have that error only after having run that (on the other hand it works if I use make build )
hzoo 2017-12-07 17:40:32 https://github.com/facebook/regenerator/pull/334
benjamn 2017-12-07 17:40:49 :tada:
hzoo 2017-12-07 17:41:03 https://twitter.com/left_pad/status/938825429955125248 tweeted too :smile:
ljharb 2017-12-07 17:54:23 that’s great, but can we still try to find ways to remove it from the defaults?
hzoo 2017-12-07 17:55:04 lol and there isn't enough interest or something i think i'm doing what I can already you're already on the thread though?
ljharb 2017-12-07 17:56:15 lol yes i am just making sure this doesn’t change the momentum :smile:
hzoo 2017-12-07 17:56:38 momentum is entirely on matt atm
benjamn 2017-12-07 17:59:35 @ljharb I’m trying to remove it from Meteor for modern browsers now, and I’m finding Regenerator handled things like async generators and for-await better than the alternatives it might still be a good default for most folks
ljharb 2017-12-07 17:59:55 maybe for those, sure and i’m def less concerned about what’s the default; but i do want babel to be able to assure correctness on, and maintain, a non-regenerator async function transform the airbnb config wouldn’t allow generators anyways, but we *want* to allow async functions, and regenerator blocks us from doing that. i’m just talking about for async functions
hzoo 2017-12-07 18:07:47 basically async to promise for the 80% case shouldn't be that hard but it's not there atm for us
benjamn 2017-12-07 18:09:02 yesterday I learned that native async functions are available in 73% of browsers worldwide just sayin’ seems pretty reasonable to use Regenerator for the shrinking 27% of browsers that don’t support async functions natively @ljharb you talk about the airbnb rules as if you don’t personally control them :stuck_out_tongue: since we never stopped using Regenerator before now, I guess we’ll be leap-frogging the other strategies so Meteor is going to start shipping untransformed async functions to those browsers
hzoo 2017-12-07 20:15:35 https://github.com/babel/babel/pull/6992
ljharb 2017-12-07 21:46:58 @benjamn lol, i don’t, or else it’d use tabs also, “worldwide” isn’t important; per-country is. and there’s some countries that are largely still using IE 9.

Related Questions